Merged
Conversation
❌ 2 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
🔄 Flaky Test DetectedAnalysis: Both failures are caused by ✅ Automatically retrying the workflow |
masterashu
approved these changes
Apr 14, 2026
jgao54
commented
Apr 14, 2026
Contributor
🔄 Flaky Test DetectedAnalysis: Both failures stem from PostgreSQL connection termination (SQLSTATE 57P01 — "terminating connection due to administrator command") and an active replication slot blocking teardown (SQLSTATE 55006), which are transient infrastructure/resource-contention issues in the concurrent e2e test environment, not code logic bugs. ✅ Automatically retrying the workflow |
Contributor
🔄 Flaky Test DetectedAnalysis: Both failures are transient: one is a snapshot status timeout (async timing issue) and the other is a PostgreSQL connection terminated by admin shutdown (SQLSTATE 57P01), neither indicating a code regression. ✅ Automatically retrying the workflow |
ilidemi
approved these changes
Apr 14, 2026
|
|
||
| // conditionallyRetryableExceptions are error codes that are only retryable | ||
| // when the error message contains one of the specified substrings | ||
| var conditionallyRetryableExceptions = map[chproto.Error][]string{ |
Contributor
There was a problem hiding this comment.
Just an idea, how about retryableExceptionSubstrings? Wouldn't need an explanation this way
Contributor
🔄 Flaky Test DetectedAnalysis: The test failed due to a transient PostgreSQL connection drop (SQLSTATE 57P01 — admin_shutdown), where the catalog DB connection was terminated by an administrator command mid-test, indicating a CI infrastructure issue rather than a code bug. ✅ Automatically retrying the workflow |
Contributor
🔄 Flaky Test DetectedAnalysis: TestGenericBQ/Test_Simple_Flow timed out waiting for STATUS_SNAPSHOT to complete — a classic transient timeout in an e2e test that depends on BigQuery and external services, with only 2 failures out of 2348 tests and the codebase itself flagging BigQuery tests as flaky under high concurrency. ✅ Automatically retrying the workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix two things:
code: 1001, message: std::__1::ios_base::failure: ios_base::clear: unspecified iostream_category error. This is a transient networking error that can happen in s3 during read and usually recovers on single retry. We want to also categorize it as retryable to avoid starting over the snapshot after a single error.